Make vertical tab strip resizable. #18567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangwoo108
force-pushed
the
sko/vtab-resize
branch
3 times, most recently
from
8366b3d to
1d0e7cc
Compare
Make the vertical tab strip resizable, with a minimum and maximum width approximately half/twice the standard tab width."
sangwoo108
force-pushed
the
sko/vtab-resize
branch
from
1d0e7cc to
81efc70
Compare
sangwoo108
requested review from
simonhong,
fallaciousreasoning and
cdesouza-chromium
and removed request for
simonhong and
fallaciousreasoning
simonhong
reviewed
May 23, 2023
| display::Screen::GetScreen()->GetCursorScreenPoint().x(); | ||
| if (!resize_offset_.has_value()) { | ||
| resize_offset_ = cursor_position - bounds_in_screen.right(); | ||
| LOG(ERROR) << *resize_offset_; |
Comment on lines
906
to
908
| if (resizing_) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I worried too much. I thought it could happen when the view is resized. Removed.
simonhong
approved these changes
May 23, 2023
Yeah, really is. Didn't have to struggle with event overriding 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the vertical tab strip resizable, with a minimum and maximum width approximately half/twice the standard tab width.
Screen.Recording.2023-05-22.at.10.08.41.PM.mov
Resolves brave/brave-browser#30322
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: