Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swap): upgrade Jupiter Swap API to v4 (uplift to 1.52.x) #18475

Merged
merged 1 commit into from
May 16, 2023
Merged

feat(swap): upgrade Jupiter Swap API to v4 (uplift to 1.52.x) #18475

merged 1 commit into from
May 16, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented May 14, 2023 •
edited by kjozwiak
Loading

Uplift of #18467

Resolves brave/brave-browser#29733
Resolves brave/brave-browser#28645
Resolves brave/brave-browser#30296
Resolves brave/brave-browser#30297

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb
feat(swap): upgrade Jupiter Swap API to v4 (#18467)
83d9390 
* feat(swap): upgrade Jupiter Swap API to v4

* review(supermassive): use EXPECT_FALSE

* review(supermassive): remove userPublicKey from swap params

We do not display fee and deposit information, so this param is not
needed for now.

* fix: lint issue

* chore: bump @brave/swap-interface to v2.1.1
@onyb onyb added this to the 1.52.x - Beta milestone May 14, 2023
@onyb onyb self-assigned this May 14, 2023
@onyb onyb requested a review from a team as a code owner May 14, 2023 01:38
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) feature/web3/wallet feature/web3/wallet/core labels May 14, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@brave/[email protected] 1.0.0...2.1.1 None +0/-0 brave.com

kjozwiak
kjozwiak approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.52.x approved 👍 QA has verified the PR on Nightly as per #18467 (comment).

@kjozwiak kjozwiak merged commit c781526 into 1.52.x May 16, 2023
@kjozwiak kjozwiak deleted the uplift-pr18467-1.52.x branch May 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@onyb @kjozwiak