Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash due to refer widget very early #18394

Merged
merged 1 commit into from
May 8, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 6, 2023

Resolves brave/brave-browser#30178

In the view control, GetWidget() should be called when it's added to widget.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

TextRecognitionBrowserTest.TextRecognitionTest

Manual test - check linked issue

fix brave/brave-browser#30178

In the view control, GetWidget() whould be called when it's added
to widget.
@simonhong simonhong self-assigned this May 6, 2023
@simonhong simonhong marked this pull request as ready for review May 6, 2023 09:09
@simonhong simonhong requested a review from sangwoo108 May 6, 2023 09:09
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 42a7b55 into master May 8, 2023
@simonhong simonhong deleted the fix_copy_text_image_crash branch May 8, 2023 00:26
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 8, 2023
brave-builds added a commit that referenced this pull request May 8, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.53.26 Chromium: 113.0.5672.77 (Official Build) nightly (64-bit)
-- | --
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS | Windows 11 Version 22H2 (Build 22621.1555)
  • Installed 1.53.26
  • launched Brave
  • navigated to search.brave.com in a new tab
  • searched for blue jay bird
  • right clicked on a thumbnail to open context menu
  • selected Copy Text From Image

Confirmed Brave no longer crashed and a dialog is shown

example example
image image

@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.53.26 Chromium: 113.0.5672.77 (Official Build) nightly (x86_64)
Revision c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.53.26
  2. launched Brave
  3. searched for blue jay bird
  4. context-clicked on an article's video-thumbnail preview
  5. chose Copy Text From Image

Confirmed I no longer crash

Copy Text From Image Text copy failed
Screen Shot 2023-05-08 at 9 31 16 AM Screen Shot 2023-05-08 at 9 31 21 AM

kjozwiak pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash while using Copy text from image
4 participants