Move hardcoded exceptions rules to more specific rules and unify exception handling #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
changed the title
srirambv
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Uplift approved after deliberating with @bsclifton and @rebron. Please update the milestone and labels on the issue
bsclifton
approved these changes
Mar 4, 2019
bbondy
force-pushed
the
exceptions-0.62.x
branch
from
81747be
to
37d55f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift request for:
#1770
This will also include:
#1828
Fix brave/brave-browser#3562
Fix brave/brave-browser#3475
Fix brave/brave-browser#3561