Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Brave Ads global state. #18021

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Refactor Brave Ads global state. #18021

merged 4 commits into from
Apr 18, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Apr 12, 2023 •
edited
Loading

Move Brave Ads manager classes global state to AdsGlobalState.

Resolves brave/brave-browser#29657

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check that an ad cannot be served with ad features enabled from the command line (i.e. --enable-features=EpsilonGreedyBandit)
  • Check that an ad can be served with ad features enabled from the command line with staging rewards (i.e. --enable-features=EpsilonGreedyBandit --rewards=staging=true )
  • Check that confirmations contains buildChannel and rotating_hash

@aseren aseren requested a review from a team as a code owner April 12, 2023 17:00
tmancey
tmancey approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ (see comments)

@aseren aseren requested a review from a team as a code owner April 13, 2023 15:26
@aseren aseren force-pushed the issues/29657 branch 8 times, most recently from 5e61642 to f6e987c Compare April 17, 2023 20:17
kylehickinson
kylehickinson requested changes Apr 17, 2023
View reviewed changes
ios/browser/api/ads/brave_ads.h Outdated Show resolved Hide resolved
ios/browser/api/ads/brave_ads.mm Outdated Show resolved Hide resolved
ios/browser/api/ads/brave_ads.mm Outdated Show resolved Hide resolved
ios/browser/api/ads/brave_ads.mm Show resolved Hide resolved
@aseren aseren requested a review from kylehickinson April 18, 2023 04:06
@aseren aseren merged commit 5c5bdd0 into master Apr 18, 2023
@aseren aseren deleted the issues/29657 branch April 18, 2023 23:19
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 18, 2023
@aseren aseren changed the title Clean-up Brave Ads manager classes. Refactor Brave Ads global state. Apr 20, 2023
@btlechowski btlechowski mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@aseren aseren

Labels
None yet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Refactor Brave Ads global state
3 participants
@aseren @kylehickinson @tmancey