Fix Brave Ads confirmation systemTimestamp user data should be recreated for retries #17584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/29005
branch
4 times, most recently
from
557276a to
333d5f4
Compare
tmancey
changed the title
tmancey
force-pushed
the
issues/29005
branch
8 times, most recently
from
63131fd to
15f9c33
Compare
aseren
reviewed
Mar 18, 2023
| *this = other; | ||
| } | ||
|
|
||
| UserDataInfo& UserDataInfo::operator=(const UserDataInfo& other) { |
There was a problem hiding this comment.
maybe we can make UserDataInfo as non-copiable?
tmancey
changed the title
tmancey
force-pushed
the
issues/29005
branch
2 times, most recently
from
4b44d9f to
154e5c1
Compare
aseren
reviewed
Mar 18, 2023
| *this = other; | ||
| } | ||
|
|
||
| OptedInUserDataInfo& OptedInUserDataInfo::operator=( |
There was a problem hiding this comment.
would it be better to do a separate Clone() method for OptedInUserDataInfo? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#29005
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Confirm systemTimestamp in payloads when redeeming unblinded tokens contains the timestamp when retrying with minutes, seconds and milliseconds set to 0 (createdAtTimestamp should be the time the confirmation was originally created).