feat(wallet): NFT Pinning design updates #17557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muliswilliam
force-pushed
the
feat-update-ipfs-pinning
branch
from
9f23cfa to
ba32629
Compare
Use media queries
muliswilliam
force-pushed
the
feat-update-ipfs-pinning
branch
from
ba32629 to
9535d4a
Compare
Douglashdaniel
requested changes
Mar 15, 2023
components/brave_wallet_ui/components/desktop/nft-ipfs-banner/nft-ipfs-banner.style.ts
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/desktop/nft-ipfs-banner/nft-ipfs-banner.style.ts
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/desktop/nft-ipfs-banner/nft-ipfs-banner.style.ts
Outdated
Show resolved
Hide resolved
…nft-ipfs-banner.style.ts Co-authored-by: Douglas Daniel <[email protected]>
cypt4
approved these changes
Mar 16, 2023
| @@ -587,7 +587,7 @@ | |||
| <message name="IDS_BRAVE_WALLET_SOLANA_ASSOCIATED_TOKEN_PROGRAM" desc="Name of Solana Associated Token Program">Associated Token Program</message> | |||
| <message name="IDS_BRAVE_WALLET_SOLANA_META_DATA_PROGRAM" desc="Name of Solana MetaData Program">MetaData Program</message> | |||
| <message name="IDS_BRAVE_WALLET_SOLANA_SYSVAR_RENT_PROGRAM" desc="Name of Solana SysvarRent Program">SysvarRent Program</message> | |||
|
|
|||
| braveWalletNftPinningCheckNftsButton: 'Check which NFTs of mine can be pinned', | ||
| braveWalletNftPinningBannerStart: 'Now you can run your IPFS and be part of web 3. Your NFT data will stay online forever and cannot be tampered with.', | ||
| braveWalletNftPinningBannerStart: 'Now you can run your IPFS and be part of web 3. Your NFT data will stay online forever.', | ||
| braveWalletNftPinningBannerUploading: 'You\’re running IPFS node. File is being uploaded to IPFS.', |
There was a problem hiding this comment.
nit: this string doesn't reflect grdp content
github-actions
bot
added
the
CI/storybook-url
muliswilliam
added a commit
that referenced
this pull request
Apr 4, 2023
* NFT Pinning design updates Use media queries * Update components/brave_wallet_ui/components/desktop/nft-ipfs-banner/nft-ipfs-banner.style.ts Co-authored-by: Douglas Daniel <[email protected]> * Remove getSuccessBackground && getSuccessBackground, use css variables --------- Co-authored-by: Douglas Daniel <[email protected]>
This was referenced Apr 4, 2023
|
Verification passed on
Verified
|
| Light | Dark |
|---|---|
 |
 |
Banner Uploading
| Light | Dark |
|---|---|
 |
 |
Banner Success
| Light | Dark |
|---|---|
 |
 |
NFT-IPFS Interstitial page
| Light | Dark |
|---|---|
 |
 |
NFT-IPFS Interstitial page (Available NFT pins)
| Light | Dark |
|---|---|
 |
 |
NFT Details page
| Light | Dark |
|---|---|
 |
 |
- Encountered brave-browser#29514
Verified https://github.com/brave/brave-browser/issues/29009 - Passed
- Verified NFT-IPFS Icon is always shown
- Verified on hover changes the button colour
- Verified still able to click the button to show/hide the message
- Verified button visibility on both dark and light theme
29009.mp4
7 tasks
brave-builds
added a commit
that referenced
this pull request
Apr 5, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Apr 5, 2023
feat(wallet): NFT Pinning design updates (#17557) * NFT Pinning design updates Use media queries * Update components/brave_wallet_ui/components/desktop/nft-ipfs-banner/nft-ipfs-banner.style.ts * Remove getSuccessBackground && getSuccessBackground, use css variables --------- Co-authored-by: Douglas Daniel <[email protected]>
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28986
Resolves brave/brave-browser#29009
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: