Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make browser launch with scrollable tabstrip flag & vertical tabstrip option #17461

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

sangwoo108
Copy link
Contributor

There was infinite loop in calculating preferred size. This caused browser not to launch at all, so make it hard to turn off the flag. This patch doesn't fully support kScrollableTabStrip flag but make it possible to open browser so that users can adjust their settings.

Resolves brave/brave-browser#28877

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Browser should open when using vertical tabs and scrollable tabstrip flag is on. But it won't work well - will handle this from another follow-up issue.

… option.

There was infinite loop in calculating preferred size. This caused
browser not to launch at all, so make it hard to turn off the flag.
This patch doesn't fully support kScrollableTabStrip flag but make it
possible to open browser so that users can adjust their settings.
@sangwoo108 sangwoo108 requested a review from simonhong March 3, 2023 12:03
@sangwoo108 sangwoo108 marked this pull request as ready for review March 3, 2023 15:02
@sangwoo108 sangwoo108 merged commit 0aebfef into master Mar 6, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-scrollable branch March 6, 2023 00:44
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use vertical Tabs + Tab Scrolling flag = Brave doesn't open
2 participants