Prevent permissive HTTPS Upgrade settings from leaking from normal to incognito windows

[arthuredelstein]

Resolves brave/brave-browser#28792

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[github-actions]

⚠️ PR head is an unsigned commit
commit: 8b9e15979cddc5acfd0749b77e5a8d2f2a68de49
reason: unsigned
Please follow the handbook to configure commit signing
cc: @arthuredelstein

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.52.2 Chromium: 112.0.5615.39 (Official Build) nightly (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Using the STR/Cases outlined via brave/brave-browser#28792 (comment), ensured the following:

Test Case #1 - Upgrade connections to HTTPS

• launched/restarted 1.52.2 Chromium: 112.0.5615.39 so BraveHttpsByDefaultRolloutStudy:Enabled
• visited http://upgradable.arthuredelstein.net in a Normal window and ensured that Upgrade connections to HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
• opened a Private window and visited http://upgradable.arthuredelstein.net and ensured Upgrade connections to HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Test Case #2 - Only connect using HTTPS

• launched/restarted 1.52.2 Chromium: 112.0.5615.39 so BraveHttpsByDefaultRolloutStudy:Enabled
• visited http://upgradable.arthuredelstein.net switched HTTPS upgrades to Only connect using HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
• opened a Private window and visited http://upgradable.arthuredelstein.net and ensured Only connect using HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Test Case #3 - Don't upgrade HTTPS connections

• launched/restarted 1.52.2 Chromium: 112.0.5615.39 so BraveHttpsByDefaultRolloutStudy:Enabled
• visited http://upgradable.arthuredelstein.net switched HTTPS upgrades to Don't upgrade HTTPS connections
• reloaded http://upgradable.arthuredelstein.net and ensured that the website was not being upgraded to HTTPS
• opened a Private window and visited http://upgradable.arthuredelstein.net and ensured Upgrade connections to HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensure that Don't upgrade HTTPS connections is NOT being used

Test Case #4 - Don't upgrade HTTPS connections (Private Window Only)

• launched/restarted 1.52.2 Chromium: 112.0.5615.39 so BraveHttpsByDefaultRolloutStudy:Enabled
• opened a Private window and visited http://upgradable.arthuredelstein.net and ensured Upgrade connections to HTTPS
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
• change the HTTPS upgrade setting to Don't upgrade HTTPS connections and load http://upgradable.arthuredelstein.net

Ensure that http://upgradable.arthuredelstein.net is not upgrade. With this case, we're basically ensuring that you can still use Don't upgrade HTTPS connections if changed within the Private window.