Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Only load http/https URLs when scanning a QR code from the URL bar #17344

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Feb 23, 2023

Resolves brave/brave-browser#28703

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Any non-http/https URL should be submitted as a search query to the users default search engine

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 23, 2023
@tapanmodh tapanmodh added this to the 1.50.x - Nightly milestone Feb 23, 2023
@tapanmodh tapanmodh self-assigned this Feb 23, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyZhukovsky
Copy link
Member

@tapanmodh could you please uplift it to 1.49.x as well, thanks!

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.72 Chromium: 111.0.5563.33 (Official Build) canary (32-bit)
--- | ---
Revision | 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS | Android 13; Build/TQ1A.230205.002

Using the STR/Cases outlined via brave/brave-ios#6997, ensured that scanning the QR code doesn't display a JS alert modal but takes the user to the default SE as per the following:

1.50.60 Chromium: 111.0.5563.33 1.50.72 Chromium: 111.0.5563.33
Screenshot_20230228-171805 Screenshot_20230228-172131

kjozwiak pushed a commit that referenced this pull request Feb 28, 2023
…URL bar (uplift to 1.49.x) (#17350)

Uplift of #17344 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only load http/https URLs when scanning a QR code from the URL bar
4 participants