Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Reduce Duplicated Strings #17069

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes duplication in our wallet Swap strings.
Since these string values are used in our Swap V2 repo, changes were first made here brave/swap#123 and we now need to bump @brave/swap-interface version to 0.14.2

Resolves brave/brave-browser#28286

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Douglashdaniel Douglashdaniel self-assigned this Feb 7, 2023
@Douglashdaniel Douglashdaniel requested review from a team as code owners February 7, 2023 07:25
@Douglashdaniel Douglashdaniel requested a review from onyb February 7, 2023 07:25
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Feb 7, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit fcf61c5 into master Feb 7, 2023
@Douglashdaniel Douglashdaniel deleted the fix-wallet-reduce-duplicated-strings branch February 7, 2023 19:51
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 7, 2023
kjozwiak pushed a commit that referenced this pull request Feb 16, 2023
* fix(wallet): Reduce Duplicated Strings

* chore: bump @brave/swap-interface to v0.14.3

---------

Co-authored-by: Douglas Daniel <[email protected]>
kjozwiak pushed a commit that referenced this pull request Feb 16, 2023
* fix(wallet): Reduce Duplicated Strings

* chore: bump @brave/swap-interface to v0.14.3

---------

Co-authored-by: Douglas Daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce duplication of strings.
5 participants