-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] fix crash enable brave news when no internet connection #17012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++. That's cool, we have users who experience that crash and I see it in GPS as well. We want to uplift it up to a stable channel as it's a problem there as well.
Verified
|
1.50.9 | 1.49.77 |
---|---|
20230204_175218.mp4 |
20230204_175707.mp4 |
Didn't see #17012 (comment) before checking so quickly went through the above as well and verified that everything seems to be working. Went through a few other cases to ensure everything was working as expected. Verification PASSED on
|
Resolves brave/brave-browser#28197
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Show Brave News
button from news card on NTP