Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Brave Ads tokens/wallet #16958

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Cleanup Brave Ads tokens/wallet #16958

merged 1 commit into from
Feb 3, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 1, 2023

Resolves brave/brave-browser#28172

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test failed confirmations are successfully redeemed. Test unblinded tokens from different wallets cannot be redeemed. Please feel free to reach out in a DM if you need further info.

@tmancey tmancey self-assigned this Feb 1, 2023
@tmancey tmancey requested review from a team as code owners February 1, 2023 18:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

⚠️ PR head is an unsigned commit
commit: 9bf2a65136489da5a62fd2450c6e0e67017ed14f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

⚠️ PR head is an unsigned commit
commit: 9bf2a65136489da5a62fd2450c6e0e67017ed14f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

⚠️ PR head is an unsigned commit
commit: 9bf2a65136489da5a62fd2450c6e0e67017ed14f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

⚠️ PR head is an unsigned commit
commit: 9bf2a65136489da5a62fd2450c6e0e67017ed14f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPS lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

⚠️ PR head is an unsigned commit
commit: b5b26eef7fb72c51aa617ff2f22e0591eda9947c
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

⚠️ PR head is an unsigned commit
commit: b5b26eef7fb72c51aa617ff2f22e0591eda9947c
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@tmancey tmancey enabled auto-merge February 2, 2023 23:44
@tmancey tmancey merged commit 4e88234 into master Feb 3, 2023
@tmancey tmancey deleted the issues/28172 branch February 3, 2023 03:46
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Brave Ads tokens/wallet
3 participants