Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fix news ntp gps crash (uplift to 1.47.x) #16909

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Android] fix news ntp gps crash (uplift to 1.47.x) #16909

merged 1 commit into from
Jan 31, 2023

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Jan 29, 2023 •
edited by kjozwiak
Loading

Uplift of #16889
Resolves brave/brave-browser#28089

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tapanmodh tapanmodh added this to the 1.47.x - Release #5 milestone Jan 29, 2023
@tapanmodh tapanmodh self-assigned this Jan 29, 2023
@tapanmodh tapanmodh requested a review from a team as a code owner January 29, 2023 07:30
@tapanmodh tapanmodh changed the title [Android] fix news ntp gps crash android (uplift to 1.47.x) [Android] fix news ntp gps crash (uplift to 1.47.x) Jan 29, 2023
kjozwiak
kjozwiak approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16890 (comment).

@kjozwiak kjozwiak merged commit 309f3cd into 1.47.x Jan 31, 2023
@kjozwiak kjozwiak deleted the fix_news_ntp_gps_crash_android_1.47.x branch January 31, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tapanmodh tapanmodh

Labels
None yet
Projects
None yet
Milestone
1.47.x - Release #6
Development

Successfully merging this pull request may close these issues.
2 participants
@tapanmodh @kjozwiak