Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for crash or no action on page bookmark #16899

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

samartnik
Copy link
Contributor

Resolves brave/brave-browser#28099

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-upstream-tests Do not run upstream unit and browser tests (otherwise run on Linux) labels Jan 27, 2023
@samartnik samartnik added this to the 1.49.x - Nightly milestone Jan 27, 2023
@samartnik samartnik self-assigned this Jan 27, 2023
@samartnik samartnik force-pushed the android_bookmark_fix branch 2 times, most recently from a602dc3 to 5acf075 Compare January 28, 2023 02:42
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_bookmark_fix branch from 5acf075 to 7c23df7 Compare January 28, 2023 21:15
@samartnik samartnik merged commit 0b19967 into master Jan 29, 2023
@samartnik samartnik deleted the android_bookmark_fix branch January 29, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-upstream-tests Do not run upstream unit and browser tests (otherwise run on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with re-bookmarking webpage / bookmark icon disabled after bookmarking again [CR110]
2 participants