Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on handling URL #16898

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Crash on handling URL #16898

merged 1 commit into from
Jan 31, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jan 27, 2023

Resolves brave/brave-browser#28087

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Tested in Emulator ,

  1. Set brave application as default
  2. from third-party application clicked one link and it's redirected to brave.
az_recorder_20230128_034341.mp4

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 27, 2023
@sujitacharya2005 sujitacharya2005 added this to the 1.49.x - Nightly milestone Jan 27, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 force-pushed the 28087_Crash_on_handling_URL branch from a63e00e to b1ef815 Compare January 30, 2023 17:26
@sujitacharya2005 sujitacharya2005 merged commit 320de29 into master Jan 31, 2023
@sujitacharya2005 sujitacharya2005 deleted the 28087_Crash_on_handling_URL branch January 31, 2023 01:15
brave-builds added a commit that referenced this pull request Jan 31, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.79 Chromium: 110.0.5481.52 (Official Build) canary (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002
  • ensured that Brave is being as the in-app web browser while set as default for the following apps:
    • Gmail, Twitter & Slack (ensured that Open in Brave within the in-app works as expected)
  • ensured that links are being opened directly within Brave when in-app is disabled via the following apps:
    • Gmail, Twitter & Slack (ensured that links are directly being opened within Brave)

Some examples of Brave being used via in-app:

Example Example Example Example
Screenshot_20230131-171933 Screenshot_20230131-171938 Screenshot_20230131-172308 Screenshot_20230131-172313

kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on handling URL
4 participants