Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NFT asset details screen (1.48.x) #16853

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Implement NFT asset details screen (1.48.x) #16853

merged 3 commits into from
Jan 31, 2023

Conversation

simoarpe
Copy link
Collaborator

@simoarpe simoarpe commented Jan 25, 2023 •
edited by kjozwiak
Loading

Uplift of #16671
Resolves brave/brave-browser#27276

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simoarpe simoarpe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 25, 2023
@simoarpe simoarpe self-assigned this Jan 25, 2023
@simoarpe simoarpe requested a review from a team as a code owner January 25, 2023 10:23
@simoarpe simoarpe added this to the 1.48.x - Beta milestone Jan 25, 2023
@simoarpe
(Wallet) Implement NFT asset details screen (#16671)
9f34c92 
Implements new NFT asset detail screen supporting GIF, BMP, PNG and JPG images.

(cherry picked from commit 15fd2dc)
@simoarpe simoarpe force-pushed the pr16671_nft-detail-screen_1.48.x branch from 47b5373 to 9f34c92 Compare January 25, 2023 12:25
@kjozwiak kjozwiak changed the title Uplift of #16671 (squashed) to beta (uplift to 1.48.x) Implement NFT asset details screen (1.48.x) Jan 31, 2023
kjozwiak
kjozwiak approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍 QA has verified the PR on Nightly as per #16671 (comment).

@kjozwiak kjozwiak merged commit b03b2e4 into 1.48.x Jan 31, 2023
@kjozwiak kjozwiak deleted the pr16671_nft-detail-screen_1.48.x branch January 31, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simoarpe simoarpe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@simoarpe @kjozwiak