Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launched additional confirmation dialog to the end of support (uplift to 1.47.x) #16734

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Launched additional confirmation dialog to the end of support (uplift to 1.47.x) #16734

merged 2 commits into from
Jan 19, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 19, 2023 •
edited by kjozwiak
Loading

Uplift of #16553 #16270
fix brave/brave-browser#27649

This PR is for uplifting #16553 but we need to uplift #16270 together because #16553 depends on #16270.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Merge pull request #16270 from brave/add_dont_show_again_button_to_ob…
f212ecc 
…solete_system_infobar

Added don't show again button to obsolete system infobar
@simonhong
Merge pull request #16553 from brave/obsolete_infobar_checkbox
f93cdf3 
Launched additional confirmation dialog to the end of support
@simonhong simonhong self-assigned this Jan 19, 2023
@simonhong simonhong requested a review from a team as a code owner January 19, 2023 00:43
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Jan 19, 2023
@kjozwiak kjozwiak added this to the 1.47.x Release #4 milestone Jan 19, 2023
kjozwiak
kjozwiak approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16553 (comment).

@kjozwiak kjozwiak merged commit 65a76a1 into 1.47.x Jan 19, 2023
@kjozwiak kjozwiak deleted the pr16553_obsolete_infobar_checkbox_1.47.x branch January 19, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.47.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @kjozwiak