Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cosmetic filters with the :has pseudoclass #16716

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#27874

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Visit https://metager.org/meta/meta.ger3?eingabe=software%20testing&focus=web&mgv=31901855042b9c5b2820d821141a7be9
  2. In standard blocking mode, there should be at least one green partnershop label on the page, to the right of a URL in the results list (note this is different from the Ad entries, whose label appears on the left side of URLs).
  3. In aggressive blocking mode, the entries previously labeled with partnershop are no longer visible.

@antonok-edm antonok-edm requested a review from bridiver January 18, 2023 03:24
@antonok-edm antonok-edm requested a review from a team as a code owner January 18, 2023 03:24
@antonok-edm antonok-edm self-assigned this Jan 18, 2023
@antonok-edm antonok-edm requested a review from rillian January 18, 2023 03:24
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support :has pseudoclass in cosmetic filters
2 participants