Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect color on Rewards page "learn more" link #16672

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jan 13, 2023

Resolves brave/brave-browser#27799

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen Shot 2023-01-13 at 2 23 51 PM

@zenparsing zenparsing requested a review from a team as a code owner January 13, 2023 19:23
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 13, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing merged commit 2b30cb8 into master Jan 13, 2023
@zenparsing zenparsing deleted the ksmith-learn-more-color branch January 13, 2023 21:53
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 13, 2023
brave-builds added a commit that referenced this pull request Jan 13, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Jan 19, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.49.40 Chromium: 109.0.5414.87 (Official Build) nightly (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 22H2 (Build 22621.1105)

Using the STR/Cases outlined via brave/brave-browser#27799 (comment), ensured that the Learn More string was correctly being displayed as per the following:

1.49.27 Chromium: 109.0.5414.87 1.49.40 Chromium: 109.0.5414.87
reproduced1 fixed1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link has incorrect color on Rewards page
4 participants