Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix brave news crash on ntp #16617

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#27753

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I'm not able to reproduce it. We got crash logs from GPS. So, just make sure brave news is working fine in ntp

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 11, 2023
@tapanmodh tapanmodh added this to the 1.49.x - Nightly milestone Jan 11, 2023
@tapanmodh tapanmodh self-assigned this Jan 11, 2023
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: af86cf8
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tapanmodh

2 similar comments
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: af86cf8
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tapanmodh

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: af86cf8
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tapanmodh

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: af86cf8
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tapanmodh

@deeppandya deeppandya merged commit 2251cc5 into master Jan 11, 2023
@deeppandya deeppandya deleted the fix_crash_brave_news_ntp_android branch January 11, 2023 21:48
brave-builds added a commit that referenced this pull request Jan 11, 2023
brave-builds added a commit that referenced this pull request Jan 11, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.22 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B1.221118.006

Verified using the STR/Cases mentioned via brave/brave-browser#27753 (comment) as per the following:

Example Example Example Example Example
Screenshot_20230111-215859 Screenshot_20230111-215910 Screenshot_20230111-220011 Screenshot_20230111-220125 Screenshot_20230111-220131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash related to Brave News on NTP
4 participants