Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better test error reporting (uplift to 1.46.x) #16523

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Better test error reporting (uplift to 1.46.x) #16523

merged 1 commit into from
Jan 4, 2023

Conversation

mherrmann
Copy link
Collaborator

@mherrmann
Let CI distinguish test compilation and test run failures (#15600)
d2f6bea 
Previously, `npm run test --output` exited with a non-zero code on both
compilation and test errors. This made it impossible to determine which
of the two happened - and thus hard to decide whether to generate test
reports. Now, the command exits with 0 on test failures. (Note that the
behavior is unchanged when --output is not given. That is, in this case
you still get non-zero exit codes for test failures.)
@mherrmann mherrmann self-assigned this Jan 4, 2023
@mherrmann mherrmann requested a review from a team as a code owner January 4, 2023 13:13
@kjozwiak kjozwiak added this to the 1.46.x - Release #7 milestone Jan 4, 2023
kjozwiak
kjozwiak approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.46.x approved 👍

@kjozwiak kjozwiak merged commit 486535d into 1.46.x Jan 4, 2023
@kjozwiak kjozwiak deleted the better-test-error-reporting-uplift-to-1.46.x branch January 4, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mherrmann mherrmann

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release #7
Development

Successfully merging this pull request may close these issues.
2 participants
@mherrmann @kjozwiak