Implement eth_subscribe newHeads #16318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Dec 9, 2022
|
Can we also update https://github.com/bbondy/eth-manual-tests and add test plan for QA using it? |
I considered first adding websocket support and then using Infura, but then eth_subscribe wouldn't be supported for user's HTTPS configured RPC endpoints. So I'm starting here with querying for block updates via the block tracker. .
bbondy
force-pushed
the
eth_subscribe
branch
from
60e51cb to
c5e5437
Compare
Yep, I'll do that today. |
Added the test plan above and made a pull request for that here: bbondy/eth-manual-tests#5 |
darkdh
approved these changes
Dec 12, 2022
|
Brave Wallet docs PR: brave/brave-wallet-docs#84 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new
eth_subscribemethod that can be used in Ethereum provider requests.See a description of this here: https://docs.infura.io/infura/networks/ethereum/json-rpc-methods/subscription-methods/eth_subscribe
This implementation only supports
newHeadsfor now.There's a follow up issue in brave/brave-browser#27283 for supporting the
"logs"param.These params are not currently supported by MM at the time of this writing, so they are probably not used in the wild and we can sit on the implementation for now:
"newPendingTransactions"and"syncing"".As an alternative to this implementation, I considered first adding websocket support and then using Infura, but then eth_subscribe wouldn't be supported for user's HTTPS configured RPC endpoints. So I'm starting here with querying for block updates via the block tracker.
If approved I will do another pull request for wallet-docs.
Resolves brave/brave-browser#21350
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
eth_subscribeto listen for new block head. You should see a console message in the developer console matching the same subscription ID every 20 seconds. You can subscribe multiple times, each time will give a new subscription ID.eth_unsubscribeto stop listening to an event by putting the subscription ID from theeth_subscribecall. It should stop ending events and return true to the console when you unsubscribe successfully from something.