Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy clean link to the macOS application menu bar #16274

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Add copy clean link to the macOS application menu bar #16274

merged 2 commits into from
Jan 19, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Dec 7, 2022 •
edited
Loading

Resolves brave/brave-browser#26825
Resolves brave/brave-browser#27676

  • No selected URL -> No Menu item

image

  • Selected text is not a url -> No Menu item

image

  • URL selected -> Menu item added

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Copy clean link Item should be visible if user has selected a url in the omnibox, otherwise the item should not be visible in the Mac menu

@spylogsster spylogsster requested review from bridiver and a team December 7, 2022 12:06
@spylogsster spylogsster self-assigned this Dec 7, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Dec 7, 2022
@spylogsster spylogsster requested a review from a team as a December 7, 2022 12:07
@spylogsster spylogsster closed this Dec 7, 2022
@spylogsster spylogsster reopened this Dec 7, 2022
@spylogsster spylogsster force-pushed the brave-26825 branch 2 times, most recently from 4866bd6 to 4bffcdd Compare December 7, 2022 14:04
@spylogsster spylogsster marked this pull request as draft December 10, 2022 12:07
@spylogsster spylogsster force-pushed the brave-26825 branch 2 times, most recently from 07fd0cf to 5c24e29 Compare December 13, 2022 12:17
@spylogsster spylogsster changed the base branch from brave-26761 to master December 13, 2022 12:17
@spylogsster spylogsster marked this pull request as ready for review December 13, 2022 12:17
@spylogsster spylogsster removed the request for review from a team December 13, 2022 12:18
@spylogsster spylogsster force-pushed the brave-26825 branch 5 times, most recently from 9572d18 to 96baed4 Compare December 13, 2022 19:38
@spylogsster spylogsster force-pushed the brave-26825 branch 2 times, most recently from f540bb6 to f364a8a Compare January 16, 2023 16:36
fmarier
fmarier approved these changes Jan 16, 2023
View reviewed changes
browser/brave_app_controller_mac.h Outdated Show resolved Hide resolved
simonhong
simonhong reviewed Jan 17, 2023
View reviewed changes
browser/brave_app_controller_mac.mm Outdated Show resolved Hide resolved
browser/brave_app_controller_mac_browsertest.mm Outdated Show resolved Hide resolved
browser/brave_app_controller_mac_browsertest.mm Show resolved Hide resolved
browser/ui/brave_browser_window.cc Show resolved Hide resolved
browser/ui/views/frame/brave_browser_view.h Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: abbd2e637ddc082d6eaf675242047289e9d2f8f0
reason: unsigned
Please follow the handbook to configure commit signing
cc: @spylogsster

simonhong
simonhong approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster force-pushed the brave-26825 branch 6 times, most recently from e214af3 to f69fdac Compare January 18, 2023 10:11
@spylogsster spylogsster requested a review from a team January 18, 2023 10:12
mkarolin
mkarolin approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src LGTM

@spylogsster spylogsster force-pushed the brave-26825 branch 3 times, most recently from 1f37d56 to 20fa85b Compare January 18, 2023 14:05
@spylogsster spylogsster merged commit 49989d4 into master Jan 19, 2023
@spylogsster spylogsster deleted the brave-26825 branch January 19, 2023 06:40
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangwoo108 sangwoo108 sangwoo108 left review comments

@mkarolin mkarolin mkarolin approved these changes

@simonhong simonhong simonhong approved these changes

@bsclifton bsclifton bsclifton approved these changes

@fmarier fmarier fmarier approved these changes

@petemill petemill Awaiting requested review from petemill

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@spylogsster spylogsster

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.

Support "Copy clean link" menu from the App menu Add copy clean link to the macOS application menu bar
7 participants
@spylogsster @bridiver @fmarier @bsclifton @sangwoo108 @simonhong @mkarolin