Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds migration for min visits #1626

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Adds migration for min visits #1626

merged 2 commits into from
Feb 18, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 8, 2019

Resolves brave/brave-browser#3250
Resolves brave/brave-browser#3277

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • create profile on the latest master
  • enable rewards
  • add some sites to ac table
  • close browser
  • open publisher db
  • change visits for all entries in activity_info to 0
  • save db
  • switch to this PR branch
  • start browser
  • visit one site
  • open db again
  • make sure that all entries in activity_info have 1 visit recorded

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler
Copy link
Contributor

@NejcZdovc can you rebase this up to Cr 73?

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler done

@NejcZdovc NejcZdovc merged commit b100b26 into master Feb 18, 2019
@NejcZdovc NejcZdovc deleted the min-visit-upgrade branch February 18, 2019 17:43
NejcZdovc added a commit that referenced this pull request Feb 18, 2019
NejcZdovc added a commit that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants