Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS by Default #16231

Closed
wants to merge 2 commits into from
Closed

HTTPS by Default #16231

wants to merge 2 commits into from

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Dec 5, 2022 •
edited
Loading

Resolves brave/brave-browser#27141

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@arthuredelstein arthuredelstein requested review from a team and iefremov as code owners December 5, 2022 15:56
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Dec 5, 2022
@arthuredelstein arthuredelstein requested a review from a team as a code owner December 5, 2022 17:52
@arthuredelstein arthuredelstein changed the title Issues/27141 HTTPS by Default Dec 5, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein marked this pull request as draft December 6, 2022 02:55
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein marked this pull request as ready for review December 12, 2022 12:20
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

arthuredelstein and others added 2 commits December 12, 2022 08:54
@arthuredelstein
HTTPS by default
e75261c 
For Desktop and Android:

- Disabled, Standard, Strict modes
- Controlled by global and per-site shields settings
- Merge UI with HTTPS-Only Mode
- Behind HttpsByDefault feature flag
- Browser tests for each setting
@arthuredelstein
Remove https-everywhere
8602a79
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein marked this pull request as draft December 14, 2022 03:32
@arthuredelstein
Copy link
Collaborator Author

Converted to draft because of a change in approach. We want to be able to enable/disable https-everywhere during the transition. That means hiding/showing the https-everywhere controls as appropriate.

@arthuredelstein
Copy link
Collaborator Author

Closing because this PR turned into a mess and I have a newer and better version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov Awaiting requested review from iefremov iefremov is a code owner

@AlexeyBarabash AlexeyBarabash Awaiting requested review from AlexeyBarabash AlexeyBarabash will be requested when the pull request is marked ready for review AlexeyBarabash is a code owner

@samartnik samartnik Awaiting requested review from samartnik samartnik will be requested when the pull request is marked ready for review samartnik is a code owner

@SergeyZhukovsky SergeyZhukovsky Awaiting requested review from SergeyZhukovsky SergeyZhukovsky will be requested when the pull request is marked ready for review SergeyZhukovsky is a code owner

@deeppandya deeppandya Awaiting requested review from deeppandya deeppandya will be requested when the pull request is marked ready for review deeppandya is a code owner

@bridiver bridiver Awaiting requested review from bridiver bridiver will be requested when the pull request is marked ready for review bridiver is a code owner

Assignees

@arthuredelstein arthuredelstein

Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTPS by Default (logic + desktop UI)
2 participants
@arthuredelstein @brave-builds