Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo and Twitter query params #16083

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Yahoo and Twitter query params #16083

merged 2 commits into from
Dec 2, 2022

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 24, 2022

Resolves brave/brave-browser#25691 and brave/brave-browser#26966.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Note: this test will only work once. After you've loaded twitter.com, you'll need to clear the profile again before you can attempt this test.

  1. Open https://brave.com/?guce_referrer=1234&guce_referrer_sig=abcd&ref_src=foobar and confirm that the URL bar only shows https://brave.com/?ref_src=foobar.
  2. Open https://twitter.com/mysk_co/status/1594515229915979776?ref_src=twsrc%5Etfw%7Ctwcamp%5Etweetembed%7Ctwterm%5E1594515229915979776%7Ctwgr%5E51cd898085c2bbd4756e89db45ddf3a06fe8ce49%7Ctwcon%5Es1_&ref_url=https%3A%2F%2Fwww.macrumors.com%2F2022%2F11%2F21%2Fapple-device-analytics-identifying-user%2F and confirm that the URL bar only shows https://twitter.com/mysk_co/status/1594515229915979776.

@fmarier fmarier requested a review from iefremov as a code owner November 24, 2022 21:09
@fmarier fmarier self-assigned this Nov 24, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Nov 24, 2022
@fmarier fmarier added this to the 1.48.x - Nightly milestone Nov 25, 2022
@fmarier fmarier changed the title Yahoo twitter query params Yahoo and Twitter query params Nov 25, 2022
@fmarier fmarier merged commit e2f8914 into master Dec 2, 2022
@fmarier fmarier deleted the yahoo-twitter-query-params branch December 2, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out Yahoo Referrer params tags
3 participants