Promoting Snowflake in Brave #15907
Merged
Promoting Snowflake in Brave #15907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
goodov
reviewed
Nov 13, 2022
|
|
||
| const bool is_allowed = | ||
| !profile->GetPrefs()->IsManagedPreference(tor::prefs::kTorDisabled) || | ||
| profile->GetPrefs()->GetBoolean(tor::prefs::kTorDisabled); |
There was a problem hiding this comment.
is this condition correct? shouldn't it be just !kTorDisabled?
There was a problem hiding this comment.
should be !managed
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
fmarier
reviewed
Nov 15, 2022
browser/resources/settings/brave_tor_page/brave_tor_snowflake_install_failed_dialog.ts
Outdated
Show resolved
Hide resolved
browser/ui/webui/settings/brave_tor_snowflake_extension_browsertest.cc
Outdated
Show resolved
Hide resolved
browser/ui/webui/settings/brave_tor_snowflake_extension_handler.cc
Outdated
Show resolved
Hide resolved
browser/ui/webui/settings/brave_tor_snowflake_extension_handler.h
Outdated
Show resolved
Hide resolved
|
A Storybook has been deployed to preview UI for the latest push |
goodov
approved these changes
Nov 16, 2022
iefremov
approved these changes
Nov 16, 2022
fmarier
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#25315
Security review: https://github.com/brave/security/issues/1023
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Since all of the functionality is contained in the extension maintained by the Tor Project, testing the extension functionality is out of scope. We should however test all of the toggle states and the Windows group policy. See the spec at https://docs.google.com/document/d/1eNUt6-dzs1DlUcCK6oWJTI51pjzIG8E3NOJ_Q_uhx88/edit#
In addition, to test that the extension is working at a very basic level, we can look for attempts at establishing an HTTPS connection to snowflake-broker.freehaven.net, the broker server that will connect proxies to clients. The webextension will connect to the broker and wait for a client.