Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic, express and expirable P3A metrics, add NTP SI/creative metrics (uplift to 1.45.x) #15745

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Nov 1, 2022

Uplift of #14595
Resolves brave/brave-browser#24318
Resolves brave/brave-browser#24319
Resolves brave/brave-browser#24609.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested a review from a team as a code owner November 1, 2022 19:44
@github-actions github-actions bot added CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Nov 1, 2022
@DJAndries DJAndries force-pushed the ntp-si-p3a-metrics-1.45.x-uplift branch from 2577943 to f9fd779 Compare November 1, 2022 21:50
…tric sent & rotation callbacks for just-in-time metric reporting
@DJAndries DJAndries force-pushed the ntp-si-p3a-metrics-1.45.x-uplift branch 2 times, most recently from a920058 to de1b906 Compare November 2, 2022 21:17
@DJAndries DJAndries force-pushed the ntp-si-p3a-metrics-1.45.x-uplift branch from de1b906 to 3554939 Compare November 2, 2022 23:04
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#24609 (comment).

@kjozwiak kjozwiak merged commit fc46cbe into 1.45.x Nov 4, 2022
@kjozwiak kjozwiak deleted the ntp-si-p3a-metrics-1.45.x-uplift branch November 4, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants