Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cosmetic filtering 1st-party checks in 3rd-party frames #15633

Merged

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#26212

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@@ -359,6 +359,7 @@ bool CosmeticFiltersJSHandler::ProcessURL(
}

enabled_1st_party_cf_ =
render_frame_->GetWebFrame()->IsCrossOriginToOutermostMainFrame() ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we need OutermostMainFrame, not the nearest one.

IsCrossOriginToNearestMainFrame

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: I believe IsCrossOriginToOutermostMainFrame is okay here, because it also cover the case of renced frames
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/frame.cc;l=212;drc=327a3573ed3d1ee29d433ee215e50947f1b94170;bpv=1;bpt=1

@antonok-edm antonok-edm merged commit 65ebc63 into master Oct 25, 2022
@antonok-edm antonok-edm deleted the disable-cosmetic-filtering-1p-checks-in-3p-frames branch October 25, 2022 17:15
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosmetic filtering] Disable checking for 1st party content in 3rd party frames
2 participants