Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbs down should dislike a Brave ad #15623

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix thumbs down should dislike a Brave ad #15623

merged 1 commit into from
Oct 24, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 24, 2022

Resolves brave/brave-browser#26202

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm "downvote" (aka dislike) confirmation is sent when disliking a Brave ad on the 30 day ads history in brave://rewards

@tmancey tmancey self-assigned this Oct 24, 2022
@tmancey tmancey requested a review from a team as a code owner October 24, 2022 13:47
@tmancey tmancey merged commit 33bfeb4 into master Oct 24, 2022
@tmancey tmancey deleted the issues/26202 branch October 24, 2022 17:52
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 24, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.47.15 Chromium: 107.0.5304.62 (Official Build) nightly (64-bit)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS Ubuntu 18.04 LTS

Verified thumbs down works as expected in UI
image

Verified downvote confirmation is sent

[8955:8955:1024/232525.213396:VERBOSE1:redeem_unblinded_token.cc(367)] Successfully redeemed unblinded token downvote confirmation for ad_notification with transaction id e9e4af00-41cb-46ca-a53a-c2363131d2a6 and creative instance id 0210de7e-2a7a-4ba7-af73-960acaac63fe

Verified the advertiser is blocked:
image

Verified the advertiser is unblocked when downvote is removed
image

Verified upvote works as expected in UI
image

Verified upvote confirmation is sent

[8955:8955:1024/233003.106059:VERBOSE1:redeem_unblinded_token.cc(367)] Successfully redeemed unblinded token upvote confirmation for ad_notification with transaction id bb6936b8-53a4-436b-a80a-578279de4aa5 and creative instance id 0210de7e-2a7a-4ba7-af73-960acaac63fe

Verified block category button works:
image
Verified the category is added to the filter list:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbs down should dislike a Brave ad
3 participants