Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ethereum provider to gin::Wrappable #15498

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Migrate ethereum provider to gin::Wrappable #15498

merged 3 commits into from
Oct 26, 2022

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 17, 2022

Resolves brave/brave-browser#19909

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test ethereum dapp by using https://github.com/bbondy/eth-manual-tests. Also please check the items in our current QA test plan for ethereum dApp.

@yrliou yrliou force-pushed the eth_provider_gin branch 2 times, most recently from e586478 to 4f980ee Compare October 18, 2022 00:38
@yrliou yrliou force-pushed the eth_provider_gin branch 2 times, most recently from 4963c28 to bf079d5 Compare October 25, 2022 18:44
@yrliou yrliou marked this pull request as ready for review October 25, 2022 18:51
@yrliou yrliou requested review from a team as code owners October 25, 2022 18:51
@yrliou yrliou changed the title [WIP] Migrate ethereum provider to gin::Wrappable Migrate ethereum provider to gin::Wrappable Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move window.ethereum to use gin
2 participants