Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Fixed auto-population in custom token and nft form #15358

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#25590

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Form.autocompletion.mov

@@ -47,7 +47,7 @@ export default function useTokenInfo (
}).catch(e => console.log(e))
}
setFoundTokenInfoByContractAddress(undefined)
}, [tokenContractAddress, visibleTokens, fullTokenList])
}, [tokenContractAddress, visibleTokens, fullTokenList, selectedNetwork])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf: update deps to only observe selectedNetwork.chainId, since it is the only property of selectedNetwork used by this effect

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@muliswilliam muliswilliam merged commit 121969a into master Oct 6, 2022
@muliswilliam muliswilliam deleted the fix-nft-form-autocompletion branch October 6, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding NFT contract address doesn't auto-populate the details the first time
3 participants