Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sidebar on right side #15315

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Enable sidebar on right side #15315

merged 2 commits into from
Oct 4, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 3, 2022 •
edited
Loading

Resolves brave/brave-browser#25332
Resolves brave/brave-browser#25756

Layout w/o vertical tab:
Screen Shot 2022-10-04 at 11 49 15 AM
Screen Shot 2022-10-04 at 11 49 29 AM

Layout with vertical tab:
Screen Shot 2022-10-04 at 11 47 26 AM
Screen Shot 2022-10-04 at 11 47 39 AM

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

SidebarBrowserTestWithVerticalTabs.SidebarRightSideTest

  1. Launch with clean profile
  2. Load brave://settings/appearance and check Side panel option is visible
  3. Check default is Show on left
  4. Select Show on right and sidebar is visible on right side
  5. Open/close any sidebar items and checks works as expected
  6. Enable vertical tab via brave://flags and re-launch
  7. Check sidebar is located properly with vertical tab

@simonhong simonhong self-assigned this Oct 3, 2022
@simonhong simonhong force-pushed the enable_sidebar_on_right_side branch 6 times, most recently from f3c632c to 46415b8 Compare October 4, 2022 01:43
@simonhong simonhong changed the title WIP: Enable sidebar on right side Enable sidebar on right side Oct 4, 2022
@simonhong simonhong force-pushed the enable_sidebar_on_right_side branch from 46415b8 to d188c7b Compare October 4, 2022 03:02
@simonhong simonhong marked this pull request as ready for review October 4, 2022 03:04
@simonhong simonhong requested a review from a team as a code owner October 4, 2022 03:04
@simonhong
Revert "Hide side panel option from settings"
4f1896a 
This reverts commit dd94847.
@simonhong
Enable sidebar on right side option
370801d 
fix brave/brave-browser#25332
fix brave/brave-browser#25756

Also custom bubble border is removed and used upstream's bubble border.
With upstream's bubble border, we don't need to care about arrow flipping
whenever changing sidebar's option.
@simonhong simonhong force-pushed the enable_sidebar_on_right_side branch from d188c7b to 370801d Compare October 4, 2022 03:50
sangwoo108
sangwoo108 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sangwoo108 sangwoo108 mentioned this pull request Oct 4, 2022
Closed
@simonhong simonhong merged commit 23edfbb into master Oct 4, 2022
@simonhong simonhong deleted the enable_sidebar_on_right_side branch October 4, 2022 11:32
@simonhong simonhong added this to the 1.46.x - Nightly milestone Oct 4, 2022
@simonhong simonhong mentioned this pull request Oct 4, 2022
Closed
@petemill
Copy link
Member

petemill commented Oct 4, 2022

nice work - follow-up we should rotate the toolbar button icon if the sidebar is shown on the right

@simonhong
Copy link
Member Author

nice work - follow-up we should rotate the toolbar button icon if the sidebar is shown on the right

Thanks for catching. I'll f/u 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@sangwoo108 sangwoo108 sangwoo108 approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.46.x - Release
4 participants
@simonhong @petemill @sangwoo108 @goodov