Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show payment status banner in rewards summary on settings page #14608

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Aug 12, 2022

Resolves brave/brave-browser#24584
Resolves brave/brave-browser#24642

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

STR included in issue description.

@emerick emerick self-assigned this Aug 12, 2022
@emerick emerick requested a review from a team as a code owner August 12, 2022 20:08
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 12, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick force-pushed the emerick-rewards-fix-rewards-summary-payout-banner branch from 0c41a41 to db6725c Compare August 16, 2022 16:10
Copy link
Collaborator

@szilardszaloki szilardszaloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick force-pushed the emerick-rewards-fix-rewards-summary-payout-banner branch from db6725c to b5461f2 Compare August 16, 2022 18:25
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 17, 2022
@emerick
Copy link
Contributor Author

emerick commented Aug 17, 2022

CI passed on everything but Windows and Linux; restarting on those platforms.

@emerick emerick force-pushed the emerick-rewards-fix-rewards-summary-payout-banner branch from b5461f2 to 5e1ffea Compare August 17, 2022 00:11
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick
Copy link
Contributor Author

emerick commented Aug 17, 2022

Windows CI passed; rerunning Linux.

@emerick
Copy link
Contributor Author

emerick commented Aug 17, 2022

CI passed on all platforms; ready to merge.

@emerick emerick merged commit ec84c91 into master Aug 17, 2022
@emerick emerick deleted the emerick-rewards-fix-rewards-summary-payout-banner branch August 17, 2022 12:56
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Aug 17, 2022
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 17, 2022
brave-builds pushed a commit that referenced this pull request Aug 17, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 18, 2022

Verification PASSED on

Brave | 1.44.52 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Issue - #24584_PASSED
  • Confirmed payment status banner is not shown on the rewards summary on setting page
  • Confirmed payout pending and payout processing messages are NOT shown in two different places at the same time
  • Confirmed payout pending banner message is shown in the rewards settings page, BR panel, NTP and BR panel on the website

unverified (non custodian connected)

Example Example Example Example
image image image image

Gemini custodian connected

Example Example Example Example
image image image image
Issue - #24642_PASSED
  • Confirmed payment status banner is NOT shown on the rewards summary on setting page
  • Confirmed payout pending and payout arrived messages are NOT shown in two different places at the same time
  • Confirmed payout pending , payment processing and payment arrived banner messages are shown in the rewards settings page, BR panel, NTP and BR panel on the website
Payment pending banner message_PASSED
Example Example Example Example
image image image image
Payment processing banner message_PASSED
Example Example Example Example
image image image image
Payment arrived banner message_PASSED
Example Example Example Example
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
5 participants