Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHECK removed in favor of character escaping. (uplift to 1.42.x) #14544

Merged
merged 1 commit into from
Aug 10, 2022
Merged

CHECK removed in favor of character escaping. (uplift to 1.42.x) #14544

merged 1 commit into from
Aug 10, 2022

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Aug 9, 2022 •
edited by kjozwiak
Loading

Uplift of #14524
Resolves brave/brave-browser#24513

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@boocmp boocmp requested a review from a team as a code owner August 9, 2022 07:30
@kjozwiak kjozwiak added this to the 1.42.x - Release #3 milestone Aug 10, 2022
kjozwiak
kjozwiak approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.42.x approved 👍 QA has verified the PR on Nightly as per #14524 (comment).

@kjozwiak kjozwiak merged commit 39c4122 into 1.42.x Aug 10, 2022
@kjozwiak kjozwiak deleted the pr14524_issues/24513_1.42.x branch August 10, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@boocmp boocmp

Labels
None yet
Projects
None yet
Milestone
1.42.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@boocmp @kjozwiak