Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import passwords for Opera #14526

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Import passwords for Opera #14526

merged 1 commit into from
Aug 16, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Aug 8, 2022

Resolves brave/brave-browser#24130

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Login and save passwords for Opera on OSX
  • Import passwords from Opera via brave://settings/importData
  • passwords imported

@spylogsster spylogsster requested a review from bsclifton August 8, 2022 12:34
@spylogsster spylogsster requested a review from a team as a code owner August 8, 2022 12:34
@spylogsster spylogsster self-assigned this Aug 8, 2022
@spylogsster spylogsster force-pushed the brave-24130 branch 4 times, most recently from 35cda11 to 8d5ca81 Compare August 12, 2022 08:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄👍

Similar solution to #14559 - LGTM.
Screen Shot 2022-08-15 at 11 37 39 PM

@spylogsster spylogsster merged commit 9c6cbff into master Aug 16, 2022
@spylogsster spylogsster deleted the brave-24130 branch August 16, 2022 06:52
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 16, 2022
brave-builds pushed a commit that referenced this pull request Aug 16, 2022
@kjozwiak
Copy link
Member

Verified for uplift by @stephendonner via #14663 (comment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Opera passwords for OSX doesn't work
4 participants