Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky split processor Rewards contribution tests #14173

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jul 14, 2022

Resolves brave/brave-browser#23817
Resolves brave/brave-browser#23816

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from a team as a code owner July 14, 2022 02:43
@zenparsing zenparsing requested a review from bsclifton July 14, 2022 02:43
@zenparsing zenparsing merged commit ce8403a into master Jul 14, 2022
@zenparsing zenparsing deleted the ksmith-disable-problem-tests branch July 14, 2022 13:34
@zenparsing zenparsing added this to the 1.43.x - Nightly milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants