-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News: use a larger IntersectionObserver viewport for pagination #14170
Conversation
… that the trigger element would be "skipped" over the viewport when scrolling down fast. Trigger position is the same (900px from the bottom of the viewport), as previously the trigger element used 900px absolute bottom position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Brave News: use a larger IntersectionObserver viewport for pagination
Brave News: use a larger IntersectionObserver viewport for pagination
Reproduced the issue on
Example of the issue occurring using the STR/Cases outlined via both brave/brave-browser#13761 (comment) & #14170 (comment). New.Tab.-.Brave.2022-07-18.17-27-31.mp4Verification PASSED on
Couldn't reproduce the original issue using the STR/Cases outlined via brave/brave-browser#13761 (comment) & #14170 (comment). Example of the issue not occurring and more news articles loading once hitting the bottom of the feed: New.Tab.-.Brave.2022-07-18.17-37-21.mp4 |
To lessen risk that the trigger element would be "skipped" over the viewport when scrolling down fast. Previously, this easily exposed the situation where further content would not be loaded since the hidden pagination trigger element had jumped from below the viewport to above the viewport, avoiding being in the viewport and triggering intersection.
This occurred for both the first "page" of content or any subsequent "pages".
Trigger position is the same (900px from the bottom of the viewport), as previously the trigger element used 900px absolute bottom position.
Resolves brave/brave-browser#13761
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: