Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used "Brave search" instead of "brave search" #14126

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 11, 2022

fix brave/brave-browser#23992

Also removed Extra ">.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong requested a review from mkarolin July 11, 2022 22:18
@simonhong simonhong self-assigned this Jul 11, 2022
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Thanks!

@simonhong simonhong merged commit 4bf79be into master Jul 12, 2022
@simonhong simonhong deleted the update_search_promotion_strings branch July 12, 2022 01:23
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 12, 2022
@simonhong
Copy link
Member Author

@mkarolin we need to uplift this change?

@mkarolin
Copy link
Collaborator

@simonhong Probably not necessary for 1.41.x, but would be good to uplift to 1.42.x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update some strings of search promotion
2 participants