Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from Opera #14006

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Import from Opera #14006

merged 3 commits into from
Jul 21, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 29, 2022

Resolves brave/brave-browser#23738

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Install Opera and have a valid profile with some usage.
  2. Visit brave://settings/importData
  3. Try to import from Opera

@spylogsster spylogsster changed the base branch from brave-13334 to brave-23704 June 29, 2022 13:35
@spylogsster spylogsster force-pushed the brave-23704 branch 21 times, most recently from 1f4b1d7 to 37b8532 Compare July 11, 2022 10:18
@spylogsster spylogsster force-pushed the brave-23704 branch 3 times, most recently from 39b315a to 9a1b334 Compare July 11, 2022 22:53
@spylogsster spylogsster force-pushed the brave-23738 branch 7 times, most recently from 24b8c82 to 33c5940 Compare July 19, 2022 16:42
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great (tested importing bookmarks, history)! P3A import type is correct, code is nice and clean

@spylogsster I tested password import and that didn't seem to work. Were you able to get that working?

@spylogsster
Copy link
Contributor Author

spylogsster commented Jul 19, 2022

Works great (tested importing bookmarks, history)! P3A import type is correct, code is nice and clean

@spylogsster I tested password import and that didn't seem to work. Were you able to get that working?

sure, fixed

@spylogsster spylogsster changed the title Import from Opera wip: Import from Opera Jul 19, 2022
@spylogsster spylogsster marked this pull request as draft July 19, 2022 19:15
@spylogsster spylogsster force-pushed the brave-23738 branch 3 times, most recently from 6284b92 to c4b8109 Compare July 20, 2022 18:40
@spylogsster spylogsster changed the title wip: Import from Opera Import from Opera Jul 21, 2022
@spylogsster spylogsster marked this pull request as ready for review July 21, 2022 05:42
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src LGTM

@spylogsster spylogsster merged commit cd486a8 into master Jul 21, 2022
@spylogsster spylogsster deleted the brave-23738 branch July 21, 2022 12:56
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import from Opera
3 participants