Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook LocalFontFaceSource into font whitelist #13779

Merged
merged 6 commits into from
Aug 2, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 14, 2022

Resolves brave/brave-browser#23432

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner June 14, 2022 17:16
@pilgrim-brave pilgrim-brave self-assigned this Jun 14, 2022
@pilgrim-brave pilgrim-brave marked this pull request as draft June 14, 2022 17:17
@pilgrim-brave pilgrim-brave marked this pull request as ready for review June 14, 2022 17:38
@pilgrim-brave pilgrim-brave marked this pull request as draft July 8, 2022 16:34
@pilgrim-brave pilgrim-brave marked this pull request as ready for review July 29, 2022 01:59
@pilgrim-brave pilgrim-brave requested a review from a team as a code owner July 29, 2022 02:06
@pilgrim-brave pilgrim-brave merged commit 617bb11 into master Aug 2, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_local_font_source branch August 2, 2022 14:57
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 2, 2022
@pes10k
Copy link
Contributor

pes10k commented Aug 2, 2022

QA test: https://dev-pages.brave.software/fingerprinting/fonts.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] Extend font randomization fingerprinting protections to also cover src:local
3 participants