Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devices each 1 second until chain is not created (0.59.x) #1348

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

AlexeyBarabash
Copy link
Contributor

Update devices each 1 second until chain is not created

Fixes brave/brave-browser#2742 .
Fixes brave/brave-browser#2782 .

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. On Device1 go to chrome://sync/
  2. Press "Start new chain" => "Computer" => "Copy code"
  3. On device 2 go to chrome://sync/
  4. "Enter sync chain code" button
  5. Paste the code
  6. "Confirm sync code" button
  7. Device1 gets created a sync chain not so late (<5 sec) after Device2

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Update devices each 1 second until chain is not created
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 15, 2019
@AlexeyBarabash AlexeyBarabash changed the title Merge pull request #1188 from brave/sync_frequent_initial_update Update devices each 1 second until chain is not created (0.59.x) Jan 15, 2019
@bbondy bbondy merged commit b6ef9a8 into 0.59.x Jan 15, 2019
@bsclifton bsclifton deleted the sync_frequent_initial_update-0.59.x branch January 24, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants