Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title for wallet menu #13457

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix title for wallet menu #13457

merged 1 commit into from
May 25, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented May 25, 2022

Resolves brave/brave-browser#23033

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. install 1.41.11
  2. launch Brave
  3. context/right-click on the Brave Wallet icon on the toolbar
  4. note its descriptive text

@spylogsster spylogsster requested a review from yrliou May 25, 2022 09:57
@spylogsster spylogsster self-assigned this May 25, 2022
@spylogsster spylogsster added this to the 1.41.x - Nightly milestone May 25, 2022
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit 8ffc31f into master May 25, 2022
@spylogsster spylogsster deleted the brave-23033 branch May 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove on toolbar in Hide Brave Wallet icon on toolbar in its context-menu text
2 participants