Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tab mute button of inactive tab is not clickable (uplift to 1.38.x) #13169

Merged
merged 1 commit into from
May 1, 2022
Merged

Fixed tab mute button of inactive tab is not clickable (uplift to 1.38.x) #13169

merged 1 commit into from
May 1, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 25, 2022 •
edited by kjozwiak
Loading

Uplift of #13043

Fixes brave/brave-browser#22081

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Merge pull request #13043 from brave/tab_audio_button_click
89e8039 
Fixed tab mute button of inactive tab is not clickable
@simonhong simonhong requested a review from a team April 25, 2022 22:04
@simonhong simonhong requested a review from a team as a code owner April 25, 2022 22:04
@simonhong simonhong self-assigned this Apr 25, 2022
@kjozwiak kjozwiak added this to the 1.38.x - Release #2 milestone Apr 26, 2022
kjozwiak
kjozwiak approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#22081 (comment).

@kjozwiak kjozwiak merged commit bc92a5f into 1.38.x May 1, 2022
@kjozwiak kjozwiak deleted the uplift_fixed_tab_mute_button_inactive_tab_1.38 branch May 1, 2022 05:55
@kjozwiak kjozwiak mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.38.x - Release #6
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhong @kjozwiak @LaurenWags