Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed shields v2 crash with multiple windows #12984

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Fixed shields v2 crash with multiple windows #12984

merged 1 commit into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. Fixed shields v2 crash with multiple windows 

    fix brave/brave-browser#22224

ShieldsPanelDataHandler should keep observed data controller
instead of getting data controller from active web contents of current
active window because active window could be different on it's created
or destroyed.
Crash happened because ShieldsPanelDataHandler tried to remove itself
from wrong data controller due to above reason.
    @simonhong
    simonhong committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c1c35b7 View commit details
    Browse the repository at this point in the history