Fix some webui that doesn't allowed in private window is loaded in private window #1295

simonhong · 2019-01-11T05:18:59Z

Some webui should not be loaded in private window.
Instead, they should be redirected to normal window.
This also fixes crash when user tries to load sync page in private window.
Sync page will be also redirected to normal window.

Fix brave/brave-browser#2853
Fix brave/brave-browser#2852

Submitter Checklist:

Test Plan:

BraveSchemeLoadBrowserTest.*PageIsNotAllowedInPrivateWindow

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

bridiver · 2019-01-11T19:42:19Z

chromium_src/chrome/browser/ui/browser_navigator.cc

+#undef Navigate
+#undef IsURLAllowedInIncognito
+
+void Navigate(NavigateParams* params) {


this is exactly what we don't want to do: try to find every place we need to hook in to map the url. We need to map it once and only once in a place that takes effect before any security checks

I tried to test this place as a replacement of current mapping not for another hooking with current one. So I inserted NOTREACHED() there.

Of course, I'll still studying navigation flow to find better place :)

yep, just need to remember that there are many, many different paths and most of the are initiated by the renderer

bridiver

see comments below

simonhong · 2019-01-18T09:35:46Z

@bridiver With this new mapping timing, previously skipped url check/verification that did for chrome ui are also applied to brave ui for browser-initiated navigation.
After #1196, renderer-initiated navigation doesn't use brave url. I spend a lot of time to investigate about navigation path and cannot find better place than this.
PTAL again.

bridiver · 2019-01-31T21:09:12Z

browser/brave_content_browser_client.cc

@@ -63,6 +63,12 @@ namespace {

 bool HandleURLRewrite(GURL* url,
                      content::BrowserContext* browser_context) {
+  if (url->SchemeIs(kBraveUIScheme)) {


seems like this should be a DCHECK

bridiver · 2019-01-31T21:10:22Z

patches/chrome-browser-ui-browser_navigator.cc.patch

+   }
+
+#if defined(BRAVE_CHROMIUM_BUILD)
+  DCHECK(!url.SchemeIs(content::kBraveUIScheme))


we definitely do not want to patch in a DCHECK here

bridiver · 2019-01-31T21:10:57Z

chromium_src/chrome/browser/browser_about_handler.cc

@@ -13,6 +13,10 @@
 bool FixupBrowserAboutURLBraveImpl(GURL* url,
                                   content::BrowserContext* browser_context) {
  if (url->SchemeIs(kBraveUIScheme)) {
+    NOTREACHED() << "brave url should not be reached here. scheme mapping "


why would we put a NOTREACHED() before a bunch of code? This does not seem correct to me

simonhong · 2019-02-01T09:29:07Z

@bridiver Rebased onto the master and I think all your comments were resolved with this rebase.
PTAL again.

bridiver · 2019-02-01T22:33:11Z

patches/chrome-browser-ui-browser_navigator.cc.patch

+            host != chrome::kChromeUISuggestionsHost;
+   }
+
+#if defined(BRAVE_CHROMIUM_BUILD)


why is this needed?

This is needed for our sync page.
Our sync page is not allowed to load private window.
That causes crash for now.

so this is a good example of what I brought up in slack today. If we create this one-off patch then someone else will have to come in and create another one if there is some other host we don't want in private tabs. We should have a chromium_src override that defines a method to call here

simonhong · 2019-02-05T06:48:52Z

@bridiver This PR will work well after merging #1573.

Some brave pages should not be loaded in private window such as brave://settings. Instead, they should be redirected to normal window. Also sync/rewards host are added to not allowed list.

Bump to 0.57.1

simonhong added the pr/work-in-progress label Jan 11, 2019

simonhong self-assigned this Jan 11, 2019

simonhong force-pushed the adjust_url_mapping_timing branch 3 times, most recently from c56a0bc to 3db9f6a Compare January 11, 2019 11:35

bridiver reviewed Jan 11, 2019

View reviewed changes

bridiver requested changes Jan 11, 2019

View reviewed changes

simonhong mentioned this pull request Jan 15, 2019

Crash when trying to open brave://sync in private window brave/brave-browser#2852

Closed

simonhong force-pushed the adjust_url_mapping_timing branch 3 times, most recently from 2e2d7fa to 83b19b3 Compare January 18, 2019 09:12

simonhong removed the pr/work-in-progress label Jan 18, 2019

simonhong changed the title ~~WIP: Adjust url mapping from brave to chrome scheme timing~~ Adjust url mapping from brave to chrome scheme timing Jan 18, 2019

simonhong changed the title ~~Adjust url mapping from brave to chrome scheme timing~~ Adjust mapping from brave to chrome scheme timing Jan 18, 2019

simonhong added this to the 0.61.x - Nightly milestone Jan 18, 2019

simonhong requested a review from bbondy January 18, 2019 09:30

simonhong removed this from the 0.61.x - Dev milestone Jan 24, 2019

bridiver reviewed Jan 31, 2019

View reviewed changes

simonhong force-pushed the adjust_url_mapping_timing branch from 83b19b3 to e9f0ccc Compare February 1, 2019 09:27

bridiver reviewed Feb 1, 2019

View reviewed changes

simonhong force-pushed the adjust_url_mapping_timing branch from e9f0ccc to d2a5854 Compare February 1, 2019 23:21

simonhong changed the title ~~Adjust mapping from brave to chrome scheme timing~~ Fix some webui that doesn't allowed in private window is loaded in private window Feb 2, 2019

simonhong force-pushed the adjust_url_mapping_timing branch 2 times, most recently from 857a3e0 to 3c89b51 Compare February 5, 2019 06:47

Fix all brave pages are loaded in private window

205f727

Some brave pages should not be loaded in private window such as brave://settings. Instead, they should be redirected to normal window. Also sync/rewards host are added to not allowed list.

simonhong force-pushed the adjust_url_mapping_timing branch from 3c89b51 to 205f727 Compare February 5, 2019 06:54

simonhong added this to the 0.62.x - Nightly milestone Feb 5, 2019

bridiver approved these changes Feb 5, 2019

View reviewed changes

simonhong merged commit efbce7a into master Feb 5, 2019

simonhong deleted the adjust_url_mapping_timing branch February 5, 2019 20:53

simonhong mentioned this pull request Feb 18, 2019

Fix crash during the sync page loading in tor(guest) window #1704

Merged

18 tasks

fmarier pushed a commit that referenced this pull request Oct 29, 2019

Merge pull request #1295 from brave/0.57.1-bump

5d90028

Bump to 0.57.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some webui that doesn't allowed in private window is loaded in private window #1295

Fix some webui that doesn't allowed in private window is loaded in private window #1295

simonhong commented Jan 11, 2019 •

edited

Loading

bridiver Jan 11, 2019

simonhong Jan 11, 2019

simonhong Jan 11, 2019

bridiver Jan 12, 2019

bridiver left a comment

simonhong commented Jan 18, 2019 •

edited

Loading

bridiver Jan 31, 2019

bridiver Jan 31, 2019

bridiver Jan 31, 2019

simonhong commented Feb 1, 2019

bridiver Feb 1, 2019

simonhong Feb 1, 2019

bridiver Feb 1, 2019

simonhong commented Feb 5, 2019

Fix some webui that doesn't allowed in private window is loaded in private window #1295

Fix some webui that doesn't allowed in private window is loaded in private window #1295

Conversation

simonhong commented Jan 11, 2019 • edited Loading

Submitter Checklist:

Test Plan:

Reviewer Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bridiver left a comment

Choose a reason for hiding this comment

simonhong commented Jan 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonhong commented Feb 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonhong commented Feb 5, 2019

simonhong commented Jan 11, 2019 •

edited

Loading

simonhong commented Jan 18, 2019 •

edited

Loading