Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up rustflags and clang toolchain paths #12947

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Apr 8, 2022

Resolves brave/brave-browser#22181

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Would be nice if too_many_personality_profiles_workaround were restricted to macos/ios, but maybe uniform optimization levels are less surprising.

@bridiver bridiver force-pushed the rust_flag_cleanup branch from 757f34c to c3f8b6a Compare April 8, 2022 16:48
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested debug/component/release builds and all good 👍

@bridiver
Copy link
Collaborator Author

bridiver commented Apr 8, 2022

CI was all green for static builds, running release builds to check use_thin_lto on/off

@bridiver bridiver added this to the 1.39.x - Nightly milestone Apr 8, 2022
@bridiver bridiver merged commit 775e329 into master Apr 8, 2022
@bridiver bridiver deleted the rust_flag_cleanup branch April 8, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize rust LTO and debug settings for different types of builds
3 participants