-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show unavailable message if user is in disconnected state #12839
Conversation
80c20dd
to
ba7307b
Compare
@zenparsing Do we want to handle the case where |
@szilardszaloki We do, I'll mark this as a draft until that's been added. |
A Storybook has been deployed to preview UI for the latest push |
ba7307b
to
e62bdd2
Compare
e62bdd2
to
2605cea
Compare
2605cea
to
7f16ec8
Compare
c9e48c3
to
c96b4cd
Compare
c96b4cd
to
2b61259
Compare
A Storybook has been deployed to preview UI for the latest push |
2b61259
to
fe221aa
Compare
A Storybook has been deployed to preview UI for the latest push |
9a9bd23
to
f31b3e2
Compare
A Storybook has been deployed to preview UI for the latest push |
f31b3e2
to
adea30e
Compare
A Storybook has been deployed to preview UI for the latest push |
adea30e
to
ddade77
Compare
A Storybook has been deployed to preview UI for the latest push |
ddade77
to
f9d9833
Compare
A Storybook has been deployed to preview UI for the latest push |
f9d9833
to
2776d90
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great!
Resolves brave/brave-browser#20991
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Screenshots
Test Plan