Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.37.x (Chromium 100) #12818

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Update l10n for 1.37.x (Chromium 100) #12818

merged 2 commits into from
Mar 29, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#21963

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner March 29, 2022 21:15
@mkarolin mkarolin self-assigned this Mar 29, 2022
@mkarolin mkarolin requested a review from emerick March 29, 2022 21:15
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin
Copy link
Collaborator Author

mkarolin commented Mar 29, 2022

CI:

  • Windows: one known browser test failed - BraveNavigatorUserAgentFarblingBrowserTest.AddBraveToNavigatorUserAgentBrandList - safe to ignore.
  • Linux: upstream unit/browser tests failed - this branch has intentionally not been rebased - safe to ignore.

@mkarolin mkarolin added this to the 1.39.x - Nightly milestone Mar 29, 2022
@mkarolin mkarolin merged commit 1066ba2 into master Mar 29, 2022
@mkarolin mkarolin deleted the maxk-1.37.x-l10n branch March 29, 2022 23:39
mkarolin added a commit that referenced this pull request Mar 29, 2022
Update l10n for 1.37.x (Chromium 100)
mkarolin added a commit that referenced this pull request Mar 30, 2022
Update l10n for 1.37.x (Chromium 100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update l10n for 1.37.x (Chromium 100)
2 participants